Repository navigation
fix(ask): harden async recovery and failed-save paths - #133
Merged
Merged
Conversation
Owner
Author
|
@greptile-apps please review |
[Medium impact] The changes affect failure recovery and answer delivery within pi-ask. Keep failed-save forms available for retry before merging. Findings
SummaryThis PR hardens question recovery and storage-failure paths without changing the tool’s input format.
One recovery gap remains: an unsaved blocking form can disappear after the conversation continues. Reviews (1) · Last reviewed commit: "fix(ask): never adopt a blocking answer ..." · Reviewed by Greptile |
A blocking form whose outcome or deferral could not be journalled was promised back to the user, but replay treated it as superseded once the conversation continued. Track failed-save ids in the runtime, keep them in the panel, and persist a defer entry once the journal accepts writes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Compatibility